shad0w/pelagia-portal
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions 1
pelagia-portal/.forgejo/PULL_REQUEST_TEMPLATE.md
Hardik 938ff6df89 test+ci: green the test baseline and make type-check + unit tests hard gates 
Green-lights the test suite so the PR checks can enforce it:
- Fix the NextAuth v5 auth() mock typing across all integration tests (cast to a
  simple async fn so mockResolvedValue accepts the session) — clears ~86 errors.
- Fix stale test values: intent 'resubmit'->'submit' / 'save'->'draft'; ParsedImportLine
  .description -> .name; approvepo -> approvePo; add missing beforeEach/beforeAll imports.
- permissions: MANAGER *can* process_payment (intentional since e1340b9) — update the
  stale assertion.
- po-import-parser: skip the Sample_PO.xlsx fixture tests when the file is absent (it
  lives outside the repo); synthetic-workbook tests still cover the parser.

type-check is now 0 errors and unit tests pass (167 passed, 13 skipped). pr-checks.yml
flips type-check (whole project) and unit tests to HARD gates.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-19 13:03:54 +05:30

890 B
Raw Blame History

What & why

Checklist

  • Tests added or updated for this change — or it is a docs/config/automation-only PR (tests not applicable). Model: the integration test on claude/issue-12 (prod-mirror DB, raw-SQL inserts, prefix-isolated, cleans up after itself).
  • Docs updated where relevant (App/README.md, App/CLAUDE.md, Docs/, automation/README.md, CHANGELOG.md).
  • pnpm type-check is clean and pnpm test passes (the PR check enforces both).
  • Verified the change (how: unit/integration tests, or a dev server on port 3100 against the test DB).